Skip to content

Conversation

@angelamayxie
Copy link
Contributor

Mostly fixes dolthub/dolt#8509 (does not handle Control+Z)

@angelamayxie angelamayxie requested a review from jycor May 29, 2025 01:28
@angelamayxie angelamayxie force-pushed the angela/escape_comments branch from a6e6050 to 5b482ea Compare May 29, 2025 01:32
@angelamayxie angelamayxie marked this pull request as ready for review May 29, 2025 17:13
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Add some ALTER TABLE tests in gms/enginetest/queries/alter_table_queries.go
Something like

	{
		Name: "alter table comments are also escaped",
		SetUpScript: []string{
			"create table t (i int);",
			`alter table t modify column i int comment ...`,
			`alter table t add column j int comment ...`,
		},
		Assertions: []ScriptTestAssertion{
			{
				Query: "show create table t",
				Expected: []sql.Row{
					{...},
				},
			},
		},
	},

@angelamayxie angelamayxie merged commit c8ab377 into main May 29, 2025
8 checks passed
@angelamayxie angelamayxie deleted the angela/escape_comments branch May 29, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SHOW CREATE TABLE doesn't properly escape quotes in comments

3 participants