add auto_increment tests with various types
#3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Jul 9, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks good!
Just a couple minor suggestions on naming. I see those tests were existing already, but thought we could still make the name a little more accurate.
| }, | ||
| }, | ||
| { | ||
| Name: "ALTER TABLE MODIFY column with multiple UNIQUE KEYS", |
Contributor
There was a problem hiding this comment.
Maybe "compound unique key" since it's really just one unique index?
Suggested change
| Name: "ALTER TABLE MODIFY column with multiple UNIQUE KEYS", | |
| Name: "ALTER TABLE MODIFY column with compound UNIQUE KEY", |
| }, | ||
| }, | ||
| { | ||
| Name: "ALTER TABLE MODIFY column with multiple KEYS", |
Contributor
There was a problem hiding this comment.
Suggested change
| Name: "ALTER TABLE MODIFY column with multiple KEYS", | |
| Name: "ALTER TABLE MODIFY column with compound KEY", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of skipped tests demonstrating MySQL
auto_incrementbehavior.