Skip to content

[no-release-notes] Refactored some shared functions into common.go #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

[no-release-notes] Refactored some shared functions into common.go #3088

merged 2 commits into from
Jul 11, 2025

Conversation

@angelamayxie
Copy link
Contributor

@angelamayxie angelamayxie commented Jul 10, 2025 •
edited
Loading

  • GetDatabase was in update.go but is used by other node types
  • getTablesToBeUpdated was duplicated

@angelamayxie angelamayxie requested a review from fulghum July 11, 2025 00:19
@angelamayxie angelamayxie marked this pull request as ready for review July 11, 2025 00:19
fulghum
fulghum approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angelamayxie angelamayxie merged commit 020a58e into main Jul 11, 2025
8 checks passed
@angelamayxie angelamayxie deleted the angela/refactor branch July 11, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fulghum fulghum fulghum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelamayxie @fulghum