Bug fix: ordered aggregates in triggers #3137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
changed the title
fulghum
force-pushed
the
fulghum/ord_agg_fix
branch
from
bbc1442 to
6e4e631
Compare
fulghum
changed the title
fulghum
force-pushed
the
fulghum/ord_agg_fix
branch
from
6e4e631 to
2bf1c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a customer-reported issue using
group_concat()in a trigger (dolthub/dolt#9616). Also changes OrderedAggregation logic to account for one output scope field per-OrderedAggregation expression.