dolthub/dolt#9624 - Fix wildcard user authentication for IP patterns #3138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add matchesHostPattern function to handle MySQL wildcard patterns like '127.0.0.%' - Modify GetUser to check both normalized host and original host against patterns - Use regex matching where % is converted to .* for proper wildcard matching - Fixes issue where users with wildcard hostnames (e.g., 'user'@'10.0.0.%') would fail authentication with 'No authentication methods available' 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- TestMatchesHostPattern: Tests the new matchesHostPattern function with various patterns - TestGetUserWithWildcardAuthentication: Tests the GetUser function with wildcard patterns - Covers IP wildcards, hostname wildcards, and edge cases - All tests pass and verify the fix works correctly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
angelamayxie
reviewed
Aug 4, 2025
angelamayxie
approved these changes
Aug 4, 2025
Contributor
angelamayxie
left a comment
angelamayxie
left a comment
There was a problem hiding this comment.
lgtm, just some minor changes in the test file
- Simplify error handling with single return statement - Avoid redundant matchesHostPattern calls when originalHost == host - Reduce verbose comments for cleaner code - Maintain same functionality with better performance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…uthentication Enhanced the integration test with 17 additional test cases covering: - IP wildcard patterns (127.0.0.%, 192.168.1.%) - Hostname wildcard patterns (%.example.com) - Global wildcard pattern (%) - Customer scenario reproduction - Both positive and negative test cases Tests verify that wildcard user authentication works correctly for various patterns that were previously failing with "No authentication methods available". 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
elianddb
force-pushed
the
elianddb/9624-fix-wildcard-user-auth
branch
from
72d077f to
0e747f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9624
Fixed wildcard user authentication that was failing with "No authentication methods available for authentication" error for patterns like 'user'@'127.0.0.%'.