avoid using sql.Row.Append()
#3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2025 11:57
fulghum
approved these changes
Aug 12, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks good!
Should we go further and completely remove the Row.Append() method and the remaining three references?
Contributor
Author
|
In the remaining uses, we actually want a deep copy of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql.Row.Append()will always make a deep copy of the row, so we should avoid it.Instead we have copies to cached
sql.Rowsor reuse the backing array throughappend()(sometimes golang's runtime will allocate a new one anyway).