implement double truncation and find correct hash comparison type #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelamayxie
reviewed
Sep 8, 2025
Contributor
angelamayxie
left a comment
angelamayxie
left a comment
There was a problem hiding this comment.
I think instead of using prepareForNumericContext (convert.go lines 359 and 369), we could be using types.ConvertOrTruncate
Then we can get rid of prepareForNumericContext if it's not called anywhere else
added 3 commits
September 8, 2025 11:32
angelamayxie
approved these changes
Sep 9, 2025
elianddb
pushed a commit
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes: dolthub/dolt#9799