Add CREATE DATABASE fall back on CREATE SCHEMA to mirror MySQL
#3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianddb
force-pushed
the
elian/dbvr-tests
branch
2 times, most recently
from
28f0dd7 to
83667c1
Compare
elianddb
force-pushed
the
elian/dbvr-tests
branch
from
f32197f to
6ee4480
Compare
fulghum
approved these changes
Sep 17, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks pretty good. Just two small requests.
enginetest/queries/script_queries.go
Outdated
| var ScriptTests = []ScriptTest{ | ||
| { | ||
| // https://github.com/dolthub/dolt/pull/9830 | ||
| Name: "CREATE SCHEMA without database selection falls back to CREATE DATABASE", |
Contributor
There was a problem hiding this comment.
This seems like it might be a better fit in the TestCreateDatabase test.
This was referenced Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9830