Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Sep 26, 2025

We weren't actually escaping any characters and just deleting all the escaped characters.

fixes: dolthub/dolt#9884

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jycor jycor merged commit c1e36e7 into main Sep 28, 2025
8 checks passed
@Webbmekanikern
Copy link

Webbmekanikern commented Sep 29, 2025

Thanks - I took a look at the code, won't this allocate like crazy? Correct me if I'm wrong, but importing e.g. 100 000 rows of 10 columns each would in this case add 2 000 000 small allocations.

Using a strings.Builder would at least cut the number in half, while a buffer pool would basically reduce it to at most 1 allocation. I'm not familiar with Dolt's codebase though and understand if the latter isn't feasible in the big picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escaped characters not handled correctly in LOAD DATA LOCAL INFILE

4 participants