Skip to content

Replace SubqueryAlias that selects an entire table with TableAlias #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2025
Merged

Replace SubqueryAlias that selects an entire table with TableAlias #3250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77eec53
remove duplicate test
angelamayxie Oct 1, 2025
7245643
replace subqueries that resolve to a whole table with an aliased vers…
angelamayxie Oct 2, 2025
f9a8d04
update tests
angelamayxie Oct 3, 2025
d2a93db
[ga-format-pr] Run ./format_repo.sh to fix formatting
angelamayxie Oct 3, 2025
e103263
add more query plan tests
angelamayxie Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions enginetest/enginetests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4915,10 +4915,6 @@ func TestSessionSelectLimit(t *testing.T, harness Harness) {
Query: "select count(*), y from (select y from a) b group by y;",
Expected: []sql.Row{{2, 1}, {3, 2}},
},
{
Query: "select count(*), y from (select y from a) b group by y;",
Expected: []sql.Row{{2, 1}, {3, 2}},
},
{
Query: "with b as (select y from a order by x) select * from b",
Expected: []sql.Row{{1}, {1}},
Expand Down
4 changes: 2 additions & 2 deletions enginetest/join_planning_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1801,12 +1801,12 @@ join uv d on d.u = c.x`,
tests: []JoinPlanTest{
{
q: "select * from t1 cross join t2 join (select * from t3) v3 on v3.k = t2.j;",
types: []plan.JoinType{plan.JoinTypeHash, plan.JoinTypeCross},
types: []plan.JoinType{plan.JoinTypeCross, plan.JoinTypeInner},
exp: []sql.Row{},
},
{
q: "select * from t1 cross join t2 join (select * from t3) v3 on v3.k >= t2.j order by i, j, k;",
types: []plan.JoinType{plan.JoinTypeInner, plan.JoinTypeCross},
types: []plan.JoinType{plan.JoinTypeCross, plan.JoinTypeInner},
exp: []sql.Row{
{1, 1, 3},
{1, 2, 3},
Expand Down
2,048 changes: 1,011 additions & 1,037 deletions enginetest/queries/integration_plans.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading