-
-
Notifications
You must be signed in to change notification settings - Fork 238
dolthub/dolt#9887: Add BINLOG and mariadb-binlog support
#3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e486d9b to
44ff54d
Compare
BINLOG SupportBINLOG and mariadb-binlog support
ab21b07 to
ff64ab8
Compare
5f5a690 to
7d07eac
Compare
fulghum
approved these changes
Nov 4, 2025
Contributor
fulghum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few minor comments.
83ff130 to
be8d29a
Compare
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9887
BinlogConsumerandBinlogConsumerCataloginterfaces.BINLOGstatement that decodes base64 encoded event strings and runs them ondolt's binlog replica applier usingBinlogConsumerinterface.mariadb-binlogutility with new format support forsql_mode,collation_database,collation_connection, andcollation_server, which can use bitmasks and IDs tied to system variable values.lc_time_names; this remains a no-op.Binlogstatement and new privilege typesbinlog_admin,replication_applier.mariadb-binlogcompatibility:skip_parallel_replication,gtid_domain_id,gtid_seq_no,check_constraint_checks,sql_if_exists,system_versioning_insert_history, andinsert_id.