Cleanup: fixing buffer reuse issues and log statements#400
Merged
Conversation
fulghum
force-pushed
the
fulghum/buffer_cleanup
branch
from
dcbcb5d to
8102050
Compare
reltuk
approved these changes
Mar 3, 2025
reltuk
left a comment
reltuk
left a comment
There was a problem hiding this comment.
LGTM! When I was here before, I looked at ComRegisterReplica and ComBinlogDumpGTID and they both looked safe to me, but it doesn't hurt to remove the recycle here either.
Author
Yeah, I think those buffers were fine, too, but seemed inconsistent with all the other calls to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.