Skip to content

dolthub/dolt#9316: Add CREATE TABLE ... AS SELECT support #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elianddb wants to merge 1 commit into from
Closed

dolthub/dolt#9316: Add CREATE TABLE ... AS SELECT support #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions go/vt/sqlparser/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2471,7 +2471,7 @@ func (node *DDL) Format(buf *TrackedBuffer) {
buf.Myprintf("%s%s table%s %v %v%v", node.Action, temporary, notExists, node.Table, node.TableSpec, node.OptSelect)
}
} else if node.OptSelect != nil {
buf.Myprintf("%s%s table%s %v %v", node.Action, temporary, notExists, node.Table, node.OptSelect)
buf.Myprintf("%s%s table%s %v%v", node.Action, temporary, notExists, node.Table, node.OptSelect)
} else {
buf.Myprintf("%s%s table%s %v", node.Action, temporary, notExists, node.Table)
}
Expand Down Expand Up @@ -2753,7 +2753,7 @@ type OptSelect struct {

// Format formats the node.
func (node *OptSelect) Format(buf *TrackedBuffer) {
buf.Myprintf("as %v", node.Select) // purposely display the AS
buf.Myprintf(" as %v", node.Select) // purposely display the AS
}

func (node *OptSelect) walkSubtree(visit Visit) error {
Expand Down Expand Up @@ -2874,18 +2874,30 @@ type TableSpec struct {
// Format formats the node.
func (ts *TableSpec) Format(buf *TrackedBuffer) {
buf.Myprintf("(\n")
emptyList := true
for i, col := range ts.Columns {
if i == 0 {
buf.Myprintf("\t%v", col)
} else {
buf.Myprintf(",\n\t%v", col)
}
emptyList = false
}
for _, idx := range ts.Indexes {
buf.Myprintf(",\n\t%v", idx)
if emptyList {
buf.Myprintf("\t%v", idx)
emptyList = false
} else {
buf.Myprintf(",\n\t%v", idx)
}
}
for _, c := range ts.Constraints {
buf.Myprintf(",\n\t%v", c)
if emptyList {
buf.Myprintf("\t%v", c)
emptyList = true
} else {
buf.Myprintf(",\n\t%v", c)
}
}
buf.Myprintf("\n)")
for _, tblOpt := range ts.TableOpts {
Expand Down
69 changes: 47 additions & 22 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8184,29 +8184,54 @@ func TestCreateTableSelect(t *testing.T) {
}, {
input: "create table `t` select pk from `foo`",
output: "create table t as select pk from foo",
}, {
input: "create table t (pk int) select val from foo",
output: "create table t (\n" +
"\tpk int\n" +
") as select val from foo",
}, {
input: "create table t (pk int) as select val from foo",
output: "create table t (\n" +
"\tpk int\n" +
") as select val from foo",
}, {
// CREATE TABLE with only indexes (no columns) and SELECT
input: "CREATE TEMPORARY TABLE t (INDEX my_index_name (tag, time), UNIQUE my_unique_index_name (order_number)) SELECT * FROM my_big_table WHERE my_val = 1",
output: "create temporary table t (\n" +
"\tINDEX my_index_name (tag, `time`),\n" +
"\tUNIQUE my_unique_index_name (order_number)\n" +
") as select * from my_big_table where my_val = 1",
}, {
// CREATE TABLE with columns, indexes, and SELECT with ENGINE option
input: `CREATE TEMPORARY TABLE core.my_tmp_table (id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, value BIGINT UNSIGNED NOT NULL DEFAULT 0 UNIQUE, location VARCHAR(20) DEFAULT "NEEDS TO BE SET", country CHAR(2) DEFAULT "XX" COMMENT "Two-letter country code", INDEX my_index_name (location)) ENGINE=MyISAM SELECT * FROM core.my_big_table`,
output: "create temporary table core.my_tmp_table (\n" +
"\tid INT unsigned not null auto_increment primary key,\n" +
"\t`value` BIGINT unsigned not null default 0 unique,\n" +
"\tlocation VARCHAR(20) default 'NEEDS TO BE SET',\n" +
"\tcountry CHAR(2) default 'XX' comment 'Two-letter country code',\n" +
"\tINDEX my_index_name (location)\n" +
") ENGINE MyISAM as select * from core.my_big_table",
}, {
// CREATE TABLE with column type override for SELECT column
input: "CREATE TABLE foo (a TINYINT NOT NULL) SELECT b+1 AS a FROM bar",
output: "create table foo (\n" +
"\ta TINYINT not null\n" +
") as select b + 1 a from bar",
}, {
// CREATE TABLE with columns from both spec and SELECT (disjoint)
input: "CREATE TABLE bar (m INT) SELECT n FROM foo",
output: "create table bar (\n" +
"\tm INT\n" +
") as select n from foo",
}, {
// CREATE TABLE with KEY shorthand
input: "CREATE TABLE test (a INT NOT NULL AUTO_INCREMENT, PRIMARY KEY (a), KEY(b)) ENGINE=InnoDB SELECT b,c FROM test2",
output: "create table test (\n" +
"\ta INT not null auto_increment,\n" +
"\tprimary key (a),\n" +
"\tKEY (b)\n" +
") ENGINE InnoDB as select b, c from test2",
}}
// TODO: Table Specs with CREATE SELECT need to be fixed
//{
// input: "create table t (pk int) select val from foo",
// output: "create table t (\n" +
// "\tpk int\n" +
// ") as select val from foo",
//}, {
// input: "CREATE TEMPORARY TABLE t (INDEX my_index_name (tag, time), UNIQUE my_unique_index_name (order_number)) SELECT * FROM my_big_table WHERE my_val = 1",
// output: "create table t(\n" +
// "\tINDEX my_index_name (tag, time)\n" +
// "\tUNIQUE my_unique_index_name (order_number)\n" +
// ") as SELECT * FROM my_big_table WHERE my_val = 1",
//}, {
// input: `CREATE TEMPORARY TABLE core.my_tmp_table (id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, value BIGINT UNSIGNED NOT NULL DEFAULT 0 UNIQUE, location VARCHAR(20) DEFAULT "NEEDS TO BE SET", country CHAR(2) DEFAULT "XX" COMMENT "Two-letter country code", INDEX my_index_name (location)) ENGINE=MyISAM SELECT * FROM core.my_big_table`,
// output: "create temporary table core.my_tmp_table (id\n" +
// "\tint unsigned not null auto_increment primary key,\n" +
// "\tvalue bigint unsigned not null default 0 unique,\n" +
// "\tlocation varchar(20) default \"need to be set\",\n" +
// "\tcountry char(2) default \"XX\" comment \"Two-letter country code\",\n" +
// "index my_index_name (location)\n" +
// ")engine=MyISAM SELECT * FROM core.my_big_table",
//},
for _, tcase := range testCases {
tree, err := Parse(tcase.input)
if err != nil {
Expand Down
Loading
Loading