Skip to content

Conversation

@nakamura-to
Copy link
Member

Summary

  • Add new domaCodeGen Gradle configuration for JDBC drivers and plugin dependencies
  • Improve dependency isolation by separating plugin classpath from main project dependencies
  • Add comprehensive tests for ClassUtil with ClassLoader support
  • Simplify test project setup using runsql-gradle-plugin

Changes

  • CodeGenPlugin: Add domaCodeGen configuration for plugin-specific dependencies
  • CodeGenConfig: Implement custom ClassLoader creation from configuration dependencies
  • ClassUtil: Add ClassLoader-aware methods for class loading and instantiation
  • Message: Add new error messages for ClassLoader-specific exceptions
  • ClassUtilTest: Comprehensive test coverage for all ClassUtil functionality
  • Test project: Updated to use new configuration and simplified database setup

Benefits

  • Better dependency management and isolation
  • Cleaner project configuration without buildscript classpath pollution
  • More robust class loading with proper error handling
  • Improved maintainability with comprehensive test coverage

Test plan

  • All existing tests pass
  • New ClassUtil tests provide comprehensive coverage
  • Integration tests work with new configuration
  • Database setup simplified in test project

🤖 Generated with Claude Code

nakamura-to and others added 2 commits June 25, 2025 23:06
Introduces a new Gradle configuration to allow users to specify JDBC drivers and other dependencies separately from their main project dependencies. This improves dependency isolation and makes it easier to configure the plugin without polluting the main classpath.

Changes:
- Add domaCodeGen configuration in CodeGenPlugin
- Update CodeGenConfig to use custom ClassLoader with configuration dependencies
- Enhance ClassUtil to support custom ClassLoader for class loading
- Update test project to use new configuration and runsql plugin for database setup

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Add ClassUtilTest with full coverage of all ClassUtil methods
- Add new error messages (DOMAGEN0033-0035) for ClassLoader-specific errors
- Improve ClassUtil implementation to properly handle ClassLoader parameter validation
- Ensure proper separation between default and ClassLoader-based class loading

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@nakamura-to nakamura-to merged commit c67a1a0 into master Jun 25, 2025
2 checks passed
@nakamura-to nakamura-to deleted the feat/configuration branch June 25, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants