Improve code quality, documentation, and use modern Java practices #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add null checks to DomaConfigBuilder methods with improved JavaDoc - Enhance exception handling in DomaAutoConfiguration with more descriptive messages - Convert DomaSpringBootSqlBuilderSettings to a Java 17 record - Update README with latest Doma version information - Update test to match new error message Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
making
reviewed
May 15, 2025
| if (connectionDetails == null) { | ||
| throw new BeanCreationException( | ||
| "No connection details available. You will probably have to set 'doma.dialect' explicitly."); | ||
| "No JdbcConnectionDetails available. Either configure a DataSource or explicitly set 'doma.dialect' property in your configuration."); |
Member
There was a problem hiding this comment.
I don't think creating a data source is relevant here.
Contributor
Author
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code quality, documentation, and use modern Java practices
This PR implements several code quality improvements across the codebase:
Changes
Added null checks to DomaConfigBuilder methods
Objects.requireNonNull()checks to all setter methodsEnhanced JavaDoc documentation in core classes
Improved exception handling in DomaAutoConfiguration
Converted DomaSpringBootSqlBuilderSettings to a Java 17 record
Updated README with latest version information
Testing
All core module tests are passing. The sample module has a version mismatch issue that is unrelated to these changes.
Link to Devin run
https://app.devin.ai/sessions/c68ec55d67574b53938341880c5b2fcb
Requested by
[email protected]