Modernize auto-configuration testing #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
backpaper0
requested changes
May 17, 2025
...utoconfigure/src/test/java/org/seasar/doma/boot/autoconfigure/DomaAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
...utoconfigure/src/test/java/org/seasar/doma/boot/autoconfigure/DomaAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
...utoconfigure/src/test/java/org/seasar/doma/boot/autoconfigure/DomaAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
…-configurations Co-Authored-By: [email protected] <[email protected]>
backpaper0
requested changes
May 18, 2025
Member
backpaper0
left a comment
backpaper0
left a comment
There was a problem hiding this comment.
Please remove unused imports.
Co-Authored-By: [email protected] <[email protected]>
backpaper0
approved these changes
May 18, 2025
backpaper0
deleted the
devin/1747472230-modernize-auto-configuration-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize auto-configuration testing
This PR modernizes the auto-configuration testing approach as described in issue #289.
Changes
AnnotationConfigApplicationContextwithApplicationContextRunner@Beforeand@Aftermethods that are no longer needed withApplicationContextRunnerEnvironmentTestUtilswith.withPropertyValues()methodAutoConfigurations.of().withUserConfiguration()for custom configuration classesThese changes align with Spring Boot's latest recommendations for testing auto-configurations as described in the documentation.
Link to Devin run: https://app.devin.ai/sessions/e3d0a2d95f8e494a80f23ea88decbdaf
Requested by: [email protected]