Skip to content

Conversation

@xterao
Copy link
Collaborator

@xterao xterao commented Apr 18, 2025

Before publishing the release notes, the task of merging the update PR for CHANGELOG.md needs to be completed.

During this process, not only will gradle.properties be updated to the release version, but the version specified in the log settings will also be updated to match the release version. This ensures that all files are updated to the same version as gradle.properties when setting the release draft or preparing the next development version after the release.

@github-actions github-actions bot added the ci CI/CD fixes label Apr 18, 2025
@xterao xterao requested a review from Copilot April 21, 2025 05:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that when releasing a new version the development build is correctly overwritten with the release version. It updates the release-drafter workflow to skip specific changelog update commits and conditionally run version update jobs.

  • Added a conditional to skip the release draft update if the branch contains "doc/changelog-update-".
  • Introduced a commit message check to determine whether to skip running the update_version job.


update_version:
needs: update_release_draft
if: ${{ needs.update_release_draft.outputs.skip_job != 'true' }}
Copy link

Copilot AI Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Ensure the 'skip_job' output is always a string, as intended, to guarantee reliable comparison; consider coercing the output if necessary.

Suggested change
if: ${{ needs.update_release_draft.outputs.skip_job != 'true' }}
if: ${{ needs.update_release_draft.outputs.skip_job != "\"true\"" }}

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logical type comparisons do not need to be enclosed in double quotes, so we will leave it as it is.

@xterao xterao merged commit 35fdcdd into main Apr 21, 2025
5 checks passed
@xterao xterao deleted the ci/set-version-with-changelog-update branch April 21, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants