Fix/document first for item #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em definition source that is defined in the field access element and uses Dao parameters.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type resolution for top-level "for" directives, centralizes common utility routines, and removes deprecated/unused classes. Key changes include fixing type lookup for DAO parameters and static property calls, moving common utility classes to a dedicated package, and deleting legacy inspection and validator classes.
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| GenerateSqlQuickFix.kt | Updated import to use the new util package for PluginLoggerUtil. |
| ForDirectiveInspection.kt | Removed unused/deprecated inspection class. |
| SqlLineMakerProvider.kt, DaoMethodProvider.kt, SqlFormatPreProcessor.kt, JumpToDaoFromSQLAction.kt, JumpToDaoFromDaoAction.kt, GenerateSqlAction.kt | Updated import references to PluginLoggerUtil to reflect package refactoring. |
| ForItemElementDocumentationProvider.kt | Refactored documentation generation logic for DAO field and static field access. |
| SqlParameterCompletionProvider.kt | Refactored field access logic in for directives using ForDirectiveUtil. |
| PluginUtil.kt & PluginLoggerUtil.kt | Updated package declarations to the new util package. |
| Various validation and for-item related classes | Deleted legacy files no longer referenced in the codebase. |
Comments suppressed due to low confidence (1)
src/main/kotlin/org/domaframework/doma/intellij/inspection/ForDirectiveInspection.kt:1
- Confirm that removing ForDirectiveInspection is deliberate and that no references to it remain in the codebase.
Entire file removed
src/main/kotlin/org/domaframework/doma/intellij/document/ForItemElementDocumentationProvider.kt
Show resolved
Hide resolved
...n/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve type resolution for top-level for directives
Centralize common logic in Util
Remove unused classes