Fixed specific element types to be treated as primitive types #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of the "_has_next" and "_index" element types to be treated as primitive types (boolean and int) rather than their wrapper types. Key changes include updates to SQL test files, adjustments to documentation string expectations in tests, and refactoring of the type resolution logic in the ForDirectiveUtil.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/testData/src/main/resources/META-INF/doma/example/dao/document/DocumentTestDao/documentForItemElementByFieldAccess.sql | Updated comment to reflect boolean treatment for employees_has_next. |
| src/test/testData/src/main/resources/META-INF/doma/example/dao/SqlCompleteTestDao/completeForItemIndex.sql | Removed unnecessary suffix (".FALSE") from the item_has_next completion. |
| src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForItemHasNextAndIndex.sql | Corrected inline references for member_has_next and member_index. |
| src/test/kotlin/org/domaframework/doma/intellij/document/SqlSymbolDocumentTestCase.kt | Updated expected type links from Boolean/Integer to boolean/int. |
| src/test/kotlin/org/domaframework/doma/intellij/complate/sql/SqlCompleteTest.kt | Adjusted completion tests to match the updated primitive type handling. |
| src/main/kotlin/org/domaframework/doma/intellij/common/util/ForDirectiveUtil.kt | Simplified type resolution using PsiTypes and added a TODO comment for error messaging. |
src/main/kotlin/org/domaframework/doma/intellij/common/util/ForDirectiveUtil.kt
Show resolved
Hide resolved
…ord-element-handling' into fix/fordirective-item-specific-word-element-handling # Conflicts: # src/main/kotlin/org/domaframework/doma/intellij/common/util/ForDirectiveUtil.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed to handle the "has_next" and "_index" element types as primitive types.
Fix for:
#150