Fix StringIndexOutOfBoundsException during file path retrieval #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a StringIndexOutOfBoundsException by adding a guard for substring extraction when the expected path substring is missing. The key changes include:
- Removal of the unused function isJavaOrKotlinFileType(VirtualFile)
- Addition of guard logic in searchDaoFile() to validate the substring index before extraction
- Inclusion of debug print statements and a TODO note for future improvements
src/main/kotlin/org/domaframework/doma/intellij/common/FileTypeCheck.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/domaframework/doma/intellij/common/FileTypeCheck.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/domaframework/doma/intellij/common/FileTypeCheck.kt
Outdated
Show resolved
Hide resolved
xterao
force-pushed
the
fix/string-indexout-of-bounds-exception
branch
from
776c2cf to
4b66649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When locating the associated SQL and DAO files, if the original file path doesn’t contain the expected substring,
String.indexOf()returns -1, causing the subsequentString.substring()call to throw an exception.Add a guard to check the result of
indexOf()and only perform the substring operation when it yields a valid index.