Fix: Assert: must be called on EDT #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where project info was being accessed off the EDT by deferring the retrieval of the active project until the settings screen is displayed. Key changes include:
- Removing the early disabling of the custom function panel in SettingComponent.
- Updating DomaToolsConfigurable to fetch the active project upon component creation and disable the panel when no project is available.
- Enhancing ActiveProjectHelper to differentiate project retrieval logic based on the EDT state.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/org/domaframework/doma/intellij/setting/SettingComponent.kt | Removed redundant code that disabled the custom function panel when no active project was available. |
| src/main/kotlin/org/domaframework/doma/intellij/setting/DomaToolsConfigurable.kt | Updated createComponent to fetch the current active project at display time and disable the panel if needed. |
| src/main/kotlin/org/domaframework/doma/intellij/common/helper/ActiveProjectHelper.kt | Refined active project retrieval logic to handle EDT and non-EDT scenarios. |
src/main/kotlin/org/domaframework/doma/intellij/setting/DomaToolsConfigurable.kt
Show resolved
Hide resolved
src/main/kotlin/org/domaframework/doma/intellij/common/helper/ActiveProjectHelper.kt
Show resolved
Hide resolved
xterao
force-pushed
the
fix/must-be-called-on-edt
branch
from
959eb71 to
d55e246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix project info retrieval off the EDT: instead of accessing project info at IDE startup, fetch the current active project when the settings screen is displayed.