Enhance SQL test data validation to support case-insensitive boolean values #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances SQL test data validation by enabling case-insensitive support for boolean and null values in list-type test data.
- Updated test data in the SQL file to include mixed-case boolean and null values.
- Modified the regex in the Kotlin file to include the case-insensitive flag (RegexOption.IGNORE_CASE) for detecting these values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/testData/src/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/commentBlock.sql | Test data updated with mixed-case boolean and null values |
| src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/visitor/SqlTestDataAfterBlockCommentVisitor.kt | Updated regex to support case-insensitive matching |
Comments suppressed due to low confidence (1)
src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/visitor/SqlTestDataAfterBlockCommentVisitor.kt:107
- [nitpick] The regex pattern is quite complex; adding inline comments or breaking it into smaller, named subpatterns would improve readability and maintainability.
Regex( """^(\(\s*(?:(?:"[^"]*"|'[^']*'|\d+|true|false|null)\s*(?:,\s*(?:"[^"]*"|'[^']*'|\d+|true|false|null)\s*)*)?\)$""",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List-type test data containing uppercase TRUE, FALSE, or NULL values are not currently recognized as valid. This change adds a case-insensitive flag to the regular expression so that true, TRUE, False, FALSE, null, NULL, etc., are all correctly detected.