Instance member suggestions missing inside static property call arguments #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves a bug in SQL completion suggestions where instance members were missing in static property call arguments. It adds several SQL test cases and corresponding DAO methods and adjusts the completion logic in SqlParameterCompletionProvider to bypass the static-field-access check when processing function-parameter elements.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| completeParameter*.sql | New SQL test files to validate completions in both static access and custom function contexts. |
| SqlCompleteTestDao.java | Added new DAO method declarations that exercise the updated SQL completion behavior. |
| SqlCompleteTest.kt | Added test functions to verify correct suggestions for instance members in various static access and custom function scenarios. |
| SqlParameterCompletionProvider.kt | Updated completion logic to skip the static-field-access element check for function-parameter elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug where, within the argument-parameter element of a function invoked on a static-access field, instance fields and methods following the top-level element were not being suggested. When suggesting completions for a child of an argument-parameter element, the static-field-access element check is now skipped.