Skip to content

Test data check skipped for directives at end of file #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Test data check skipped for directives at end of file #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...domaframework/doma/intellij/inspection/sql/visitor/SqlTestDataAfterBlockCommentVisitor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,15 @@ class SqlTestDataAfterBlockCommentVisitor(
super.visitBlockComment(element)
if (hasOtherBindVariable(element)) return

val nextElement = element.nextSibling ?: return
val result = ValidationTestDataResult(element, shortName)
val nextElement = element.nextSibling
if (nextElement == null) {
result.highlightElement(holder)
return
}
if (isSqlLiteral(nextElement)) return
if (isMatchListTestData(element)) return

val result = ValidationTestDataResult(element, shortName)
result.highlightElement(holder)
}

Expand Down
1 change: 1 addition & 0 deletions ...src/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/commentBlock.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ SELECT e.employee_id AS employeeId
AND e.age >= /*^ literalAge */99
AND e.sub_id IN /* subIds */(1, 2, 3)
AND e.sub_id IN /* subIds */(true, False, NULL)
AND e.final IN <error descr="Test data is required after a bind variable directive or a literal variable directive">/* literalAge */</error>
Loading