Add fallback for parent class name retrieval in validation property result #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds handling for primitive types in validation error messaging and corresponding tests
- Introduces a fallback to use the type’s
canonicalTextwhen retrieving a parent class name - Adds a SQL test case for accessing a non-existent property on a primitive (
boolean)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForEntityAndNonEntityParentClass.sql | Added a test case for property access on a primitive type |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationPropertyResult.kt | Fallback to type.canonicalText when parent class name is missing |
...tlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationPropertyResult.kt
Outdated
Show resolved
Hide resolved
...ETA-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForEntityAndNonEntityParentClass.sql
Show resolved
Hide resolved
xterao
force-pushed
the
fix/add-message-condition-non-psitype
branch
from
6c4989c to
fe6b7af
Compare
xterao
force-pushed
the
fix/add-message-condition-non-psitype
branch
from
fe6b7af to
42a29f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the error message and add test cases for when a property is accessed on a primitive type during the field-access element definition check.