Skip to content

Conversation

@xterao
Copy link
Collaborator

@xterao xterao commented Jun 16, 2025

Implement a process to check for the presence of a unique asterisk in the test data check for the Expand directive.

@xterao xterao requested a review from Copilot June 16, 2025 01:33
@xterao xterao self-assigned this Jun 16, 2025
@github-actions github-actions bot added the fix Bug fixes label Jun 16, 2025
@xterao xterao linked an issue Jun 16, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to correctly check for the presence of an asterisk after the expand variable directive in SQL test data files. Key changes include:

  • New SQL test files for valid and invalid expand directives.
  • Additional DAO methods and inspection logic for expand directives.
  • Updated test cases and error messages to support the new expand directive check.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/test/testData/src/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/invalidExpandDirective.sql Added test file to validate error when expand directive is missing the required asterisk.
src/test/testData/src/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/expandDirective.sql Added test file verifying proper use of the expand directive with the asterisk.
src/test/testData/src/main/java/doma/example/dao/inspection/TestDataCheckDao.java Introduced new DAO methods for expand directive testing.
src/test/kotlin/org/domaframework/doma/intellij/inspection/sql/TestDataCheckTest.kt Extended test coverage with expand directive tests.
src/main/resources/messages/DomaToolsBundle_ja.properties
src/main/resources/messages/DomaToolsBundle.properties
Updated error messages for invalid expand directive cases.
src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/visitor/SqlTestDataInspectionVisitor.kt Implemented logic to detect and validate the expand directive in SQL comments.

@xterao xterao merged commit 9e21a47 into main Jun 16, 2025
5 checks passed
@xterao xterao deleted the fix/expand-directive-incorrectly-treated branch June 16, 2025 04:29
@xterao xterao added this to the 1.1.0 Release milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand directive incorrectly treated as bind variable directive

2 participants