Fixes to Annotation Option Validation #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes three issues in the annotation option validation functionality for Doma tools: primitive type property handling, property access validation on primitive types, and non-array option value support.
- Fixed bug where primitive type properties in include/exclude options incorrectly triggered errors
- Added dedicated error message for property access attempts on primitive types
- Enhanced parsing to handle single string values instead of only arrays for include/exclude options
Reviewed Changes
Copilot reviewed 21 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/.../DaoAnnotationOptionParameterCheckProcessor.kt | Core logic fixes for option validation including primitive type handling and single string parsing |
| src/main/kotlin/.../ValidationAnnotationOptionPrimitiveFieldResult.kt | New validation result class for primitive field access errors |
| src/main/kotlin/.../PsiParameterExtension.kt | Fixed parameter type access using type instead of typeElement?.type |
| src/main/kotlin/.../PsiMethodExtension.kt | Enhanced parameter finding to exclude ignored parameter types |
| src/main/resources/messages/DomaToolsBundle*.properties | Added error message for primitive field access validation |
| Test files | Comprehensive test data and test cases for the new functionality |
.../doma/intellij/inspection/dao/processor/option/DaoAnnotationOptionParameterCheckProcessor.kt
Show resolved
Hide resolved
.../doma/intellij/inspection/dao/processor/option/DaoAnnotationOptionParameterCheckProcessor.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses the following issues in the annotation option checking functionality:
Primitive type property handling
Fixed a bug where specifying a primitive type property in include or exclude options would incorrectly trigger an error.
Property access on primitive types
Added a dedicated error message when a property access is performed on a primitive type (e.g., attempting to reference a sub-property of an int).
Non-array option value support
Enhanced parsing to correctly handle cases where include or exclude values are provided as a single string instead of an array.