Fix: Freeze During SQL Formatting #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the SQL formatter on certain SQL statements causes IntelliJ IDEA to freeze.
This issue occurs specifically when a literal value (number, string, boolean, etc.) is passed as a parameter in a method call.
Problem case: Literals used as method call parameters.
Not affected: Cases where DAO method parameters are used, or when literals are used outside of method parameters.
Example that triggers the freeze:
The formatter now handles this case without causing IDEA to hang.
Fix Details
Properly implemented child block parsing within parameter blocks.
Ensured a Primary block is generated so that spacing settings do not return null.