-
Notifications
You must be signed in to change notification settings - Fork 0
Fix: SQL Formatter #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix: SQL Formatter #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
…ne-breaks Fix IN Clause Formatting
…larity and accuracy
Fix subquery formatting under conditional directives
Fix formatting for EXISTS clause
…lArrayWordBlock for clarity
…parison-operators Fix SQL formatting rules for JSON columns
…nnecessary spaces in function parameters
…in SQL formatting
…t-formatting-function-in-condition-directive Formatting of SQL Function Parameters with Keyword Elements
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and enhances the SQL formatter block logic, focusing on improved handling of condition loop directives, block spacing rules, and better support for array/list SQL constructs. The changes increase code maintainability, readability, and extensibility, especially around comment and directive formatting and array/list parsing.
Condition Loop Directive Handling
Spacing and Indentation Refactoring
Also, corrected the calculation of indentation for subqueries used in conditional expressions.
Array/List Block Support
SqlArrayListGroupBlock,SqlArrayWordBlock) and logic to correctly parse and format SQL array/list constructs, including handling of escape characters and block relationships. [1] [2] [3]Block Construction and Child Block Parsing
Function Name and Keyword Handling
These changes collectively improve the formatter’s ability to handle complex SQL structures, especially those involving conditional logic and arrays/lists, while making the codebase easier to maintain and extend.