Skip to content

Add Char type to the condition as a literal #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add Char type to the condition as a literal #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...org/domaframework/doma/intellij/inspection/sql/inspector/SqlBindVariableValidInspector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ class SqlBindVariableValidInspector : LocalInspectionTool() {
private fun isLiteralOrStatic(targetElement: PsiElement): Boolean =
(
targetElement.firstChild?.elementType == SqlTypes.EL_STRING ||
targetElement.firstChild?.elementType == SqlTypes.EL_CHAR ||
targetElement.firstChild?.elementType == SqlTypes.EL_NUMBER ||
targetElement.firstChild?.elementType == SqlTypes.EL_NULL ||
targetElement.firstChild?.elementType == SqlTypes.EL_BOOLEAN ||
Expand Down
2 changes: 2 additions & 0 deletions ...-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForEntityAndNonEntityParentClass.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ INSERT INTO employee_project (employee_name, department, project)
FROM
employee e1
JOIN user u1 ON e1.employee_id = u1.user_id
AND e1.user_tag = /*# 't' */'a'
AND e1.user_dept = /*# "development" */'dev'
-- Access to parent private field
WHERE u1.user_name = /* employee.userName.toLowerCase() */'name'
-- Access to non-existent parent field
Expand Down
Loading