inspection in function parameters #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/test/testData/src/main/resources/META-INF/doma/example/dao/DaoMethodVariableInspectionTestDao/noErrorWhenUsedInFunctionParameters.sql: Language not supported
- src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableInFunctionParameters.sql: Language not supported
src/test/kotlin/org/domaframework/doma/intellij/inspection/sql/ParameterDefinedTest.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/test/testData/src/main/resources/META-INF/doma/example/dao/DaoMethodVariableInspectionTestDao/noErrorWhenUsedInFunctionParameters.sql: Language not supported
- src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableInFunctionParameters.sql: Language not supported
src/test/kotlin/org/domaframework/doma/intellij/inspection/sql/ParameterDefinedTest.kt
Outdated
Show resolved
Hide resolved
xterao
force-pushed
the
fix/inspection-in-function-parameters
branch
from
179690d to
41b7e80
Compare
Co-authored-by: Copilot <[email protected]>
xterao
force-pushed
the
fix/inspection-in-function-parameters
branch
from
41b7e80 to
07b3113
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/test/testData/src/main/resources/META-INF/doma/example/dao/DaoMethodVariableInspectionTestDao/noErrorWhenUsedInFunctionParameters.sql: Language not supported
- src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableInFunctionParameters.sql: Language not supported
Comments suppressed due to low confidence (1)
src/test/kotlin/org/domaframework/doma/intellij/inspection/sql/ParameterDefinedTest.kt:84
- The test for bindVariableInFunctionParameters seems to be incomplete as it does not invoke myFixture.testHighlighting. Consider adding a call to myFixture.testHighlighting to validate that the inspection works correctly for bind variable definitions in function parameters.
if (sqlFile == null) return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the bind variables within function parameters to the inspection that checks for bind variable definitions.