Skip to content

fix crash caused by loading an empty game; also slightly bring down t… #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domino14 merged 1 commit into from
Mar 4, 2026
Merged

fix crash caused by loading an empty game; also slightly bring down t… #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func DefaultConfig() *Config {

c.SetDefault(ConfigDefaultLexicon, "NWL23")
c.SetDefault(ConfigDefaultLetterDistribution, "English")
c.SetDefault(ConfigTtableMemFraction, 0.25)
c.SetDefault(ConfigTtableMemFraction, 0.20)
c.SetDefault(ConfigDefaultBoardLayout, "CrosswordGame")
c.SetDefault(ConfigTritonUseTriton, false)
c.SetDefault(ConfigTritonURL, "localhost:8001")
Expand Down Expand Up @@ -155,7 +155,7 @@ func (c *Config) Load(args []string) error {
c.SetDefault(ConfigDataPath, "./data") // will be fixed by toAbsPath below if unspecified.
c.SetDefault(ConfigDefaultLexicon, "NWL23")
c.SetDefault(ConfigDefaultLetterDistribution, "English")
c.SetDefault(ConfigTtableMemFraction, 0.25)
c.SetDefault(ConfigTtableMemFraction, 0.20)
c.SetDefault(ConfigDefaultBoardLayout, "CrosswordGame")
c.SetDefault(ConfigTritonURL, "localhost:8001")
c.SetDefault(ConfigTritonModelName, "macondo-nn")
Expand Down
8 changes: 4 additions & 4 deletions endgame/negamax/transposition_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,10 @@ func (t *TranspositionTable) Reset(fractionOfMemory float64, boardDim int) {

p := message.NewPrinter(language.English)
log.Info().
Str("num-elems", p.Sprintf("%d", numElems)).
Str("desired-num-elems", p.Sprintf("%.0f", desiredNElems)).
Str("estimated-total-memory-bytes", p.Sprintf("%d", numElems*entrySize)).
Str("mem-limit", p.Sprintf("%d", totalMem)).
Str("allocated-elems", p.Sprintf("%d", numElems)).
Str("desired-elems", p.Sprintf("%.0f", desiredNElems)).
Str("allocated-bytes", p.Sprintf("%d", numElems*entrySize)).
Str("memory-budget", p.Sprintf("%d", totalMem)).
Bool("reset", reset).
Msg("transposition-table-size")

Expand Down
2 changes: 1 addition & 1 deletion gcgio/gcg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ func ParseGCGFromReader(cfg *config.Config, reader io.Reader) (*pb.GameHistory,
parser.history.OriginalGcg = strings.TrimSpace(originalGCG)

// Determine if the game ended.
if parser.game.Playing() == pb.PlayState_GAME_OVER {
if parser.game != nil && parser.game.Playing() == pb.PlayState_GAME_OVER {
parser.history.PlayState = pb.PlayState_GAME_OVER
parser.game.AddFinalScoresToHistory()
}
Expand Down