fix: remove truncation of racks and moves in analysis output#459
Open
fix: remove truncation of racks and moves in analysis output#459
Conversation
Fixes #453 Previously, the analysis output was truncating player names, racks, and move descriptions using byte-level string slicing (e.g., rack[:8]). This corrupted multi-byte UTF-8 characters like Polish diacritics (ą, ć, ę, ł, ń, ó, ś, ź, ż), causing invalid UTF-8 sequences to appear as � replacement characters. Changes: - Removed truncation for racks (max 7 tiles, should always show in full) - Removed truncation for move descriptions (better to show full move) - Updated player name truncation to use rune-based slicing instead of byte-based to safely handle UTF-8 characters The format strings (%-12s, %-8s, etc.) set minimum widths but don't truncate, so longer values will naturally use more space without corruption. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453
Previously, the analysis output was truncating player names, racks, and move descriptions using byte-level string slicing (e.g., rack[:8]). This corrupted multi-byte UTF-8 characters like Polish diacritics (ą, ć, ę, ł, ń, ó, ś, ź, ż), causing invalid UTF-8 sequences to appear as � replacement characters.
Changes:
The format strings (%-12s, %-8s, etc.) set minimum widths but don't truncate, so longer values will naturally use more space without corruption.