Vary style Rule value handling based on type #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Rule can return a RuleValueList or a string depending on the CSS property being parsed. A format handler must be supplied when rendering the RuleValueList.
There was a problem hiding this comment.
Pull request overview
This PR improves CSS Rule value handling in the Style class by differentiating between RuleValueList objects (which require an OutputFormat parameter for rendering) and string values (which can be cast directly). The change prevents errors when processing different CSS property types.
Key Changes:
- Introduces an
OutputFormatinstance for rendering CSS values - Adds type checking to handle both
Valueinstances and strings appropriately - Applies the fix to both class selector and tag selector processing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bsweeney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Rule can return a RuleValueList or a string depending on the CSS property being parsed. A format handler must be supplied when rendering the RuleValueList.