Add CRA typescript template with web & service worker #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this PR is abandoned or not, but I'd suggest using comlink. It would make code simpler and easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration on a template that not only uses webworkers to not block the main ui thread, but also makes use of a service worker to cache opencascade.js files for faster resumption when visiting the page again.
The template is based on the newest cra-template-pwa-typescript from create-react-app. So this template is very up to date compared to the Create-React-App templates.
Im not sure if this template should be combined with the webworker template. Since i am not sure if it is a good idea to have additional boilerplate code for developers that do not intent to use the service worker at all.