Skip to content

Fix arg_completions function#150

Open
cyblue9 wants to merge 1 commit intodonnemartin:masterfrom
cyblue9:feature/fix_arg_completions_function
Open

Fix arg_completions function#150
cyblue9 wants to merge 1 commit intodonnemartin:masterfrom
cyblue9:feature/fix_arg_completions_function

Conversation

@cyblue9
Copy link
Copy Markdown
Contributor

@cyblue9 cyblue9 commented Aug 9, 2018

Fixed that arg is displayed even if the subcommand is wrong.

before:
"hoge" is wrong subcommand. but, arg suggestion("10 limit: int (opt) limits the posts displayed") is displayed.

haxor> hn hoge
               10     limit: int (opt) limits the posts displayed

after:
"hoge" is wrong subcommand. so, suggestion is not displayed.

haxor> hn hoge

Please confirm!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #150 into master will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   93.53%   93.47%   -0.06%     
==========================================
  Files          31       31              
  Lines        1469     1471       +2     
==========================================
+ Hits         1374     1375       +1     
- Misses         95       96       +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants