Skip to content

build: switch back to official eastl#1716

Merged
doodlum merged 1 commit intodoodlum:devfrom
alandtse:eastl_restore
Jan 15, 2026
Merged

build: switch back to official eastl#1716
doodlum merged 1 commit intodoodlum:devfrom
alandtse:eastl_restore

Conversation

@alandtse
Copy link
Collaborator

@alandtse alandtse commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Removed a runtime CMake version check that previously produced a hard error for newer CMake releases.
    • Removed a temporary vcpkg registry configuration.
    • Updated the project manifest's builtin baseline reference.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 14, 2026 22:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

Removed a CMake runtime error that aborted generation on CMake >= 4.0.0, deleted a git-based vcpkg registry config for EASTL, and updated the builtin-baseline value in vcpkg.json.

Changes

Cohort / File(s) Summary
CMake Configuration
CMakeLists.txt
Deleted the conditional if(CMAKE_VERSION VERSION_GREATER_EQUAL "4.0.0") ... ERROR ... endif block that produced a hard error for CMake ≥ 4.0.0.
VCPkg Registry
vcpkg-configuration.json
Removed the git-based registry entry referencing the temporary eastl-3.27.1 stable branch (registry metadata and packages).
VCPkg Manifest
vcpkg.json
Updated the builtin-baseline commit hash from fafcc0e9...6d449b to 7a6bb52b...503e42e (no other manifest changes).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • doodlum
  • jiayev

Poem

🐰
CMake gates that once stood tall, now fall,
vcpkg branches trimmed from the hall,
Baselines nudged, the build paths light,
Hop onward, coders—debugs take flight! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build: switch back to official eastl' clearly and concisely summarizes the main change—removing temporary/custom eastl configuration and reverting to official sources.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbc2aa8 and ee47abb.

📒 Files selected for processing (3)
  • CMakeLists.txt
  • vcpkg-configuration.json
  • vcpkg.json
💤 Files with no reviewable changes (2)
  • vcpkg-configuration.json
  • CMakeLists.txt
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

  1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
    if the existing title does not describe the code changes):
    Format: type(scope): description
    Length: 50 characters limit for title, 72 for body
    Style: lowercase description, no ending period
    Examples:

    • feat(vr): add cross-eye sampling
    • fix(water): resolve flowmap bug
    • docs: update shader documentation
  2. Issue References (if PR fixes bugs or implements features):
    Suggest adding appropriate GitHub keywords:

    • "Fixes #123" or "Closes #123" for bug fixes
    • "Implements #123" or "Addresses #123" for features
    • "Related to #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

  • vcpkg.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run Shader Unit Tests
  • GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)
  • GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)
  • GitHub Check: Build plugin and addons
🔇 Additional comments (1)
vcpkg.json (1)

60-60: Baseline update is properly configured for switching to official EASTL.

The baseline commit 7a6bb52bfd8eba088f8bf5cae70ca8d81503e42e contains the specified override versions: eastl 3.27.1 and eabase 2025-08-01 are both available and accessible. The change aligns with the PR objective and should build without issues.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Using provided base ref: f8aa7a2
Using base ref: f8aa7a2
Base commit date: 2026-01-13T15:11:17Z (Tuesday, January 13, 2026 03:11 PM)
No actionable suggestions for changed features.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the temporary vcpkg custom registry configuration that was used to access eastl 3.27.1 before it was available in the official vcpkg repository. The change indicates that the upstream PR (microsoft/vcpkg#49228) has been merged, allowing the project to use the official vcpkg registry.

Changes:

  • Removed custom vcpkg registry configuration that pointed to a temporary eastl fork
  • Removed CMake version check that warned about eastl installation issues with CMake 4.0+

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vcpkg-configuration.json Entire file deleted - removes custom registry pointing to temporary eastl 3.27.1 fork
CMakeLists.txt Removes CMake 4.0+ version check that was warning about eastl vcpkg installation issues

@github-actions
Copy link

✅ A pre-release build is available for this PR:
Download

@doodlum doodlum merged commit 4fc8530 into doodlum:dev Jan 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants