build: switch back to official eastl#1716
Conversation
📝 WalkthroughWalkthroughRemoved a CMake runtime error that aborted generation on CMake >= 4.0.0, deleted a git-based vcpkg registry config for EASTL, and updated the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🧰 Additional context used📓 Path-based instructions (1)**/*⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the temporary vcpkg custom registry configuration that was used to access eastl 3.27.1 before it was available in the official vcpkg repository. The change indicates that the upstream PR (microsoft/vcpkg#49228) has been merged, allowing the project to use the official vcpkg registry.
Changes:
- Removed custom vcpkg registry configuration that pointed to a temporary eastl fork
- Removed CMake version check that warned about eastl installation issues with CMake 4.0+
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vcpkg-configuration.json | Entire file deleted - removes custom registry pointing to temporary eastl 3.27.1 fork |
| CMakeLists.txt | Removes CMake 4.0+ version check that was warning about eastl vcpkg installation issues |
cbc2aa8 to
ee47abb
Compare
|
✅ A pre-release build is available for this PR: |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.