Respect Doorkeeper's configured pkce_code_challenge_methods
#226
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `code_challenge_methods` were hardcoded to `plain` and `S256`. This will cause a mismatch between the configured challenge methods and those that were advertised. Update to delegate to `doorkeeper#pkce_code_challenge_methods` so that the supported methods exposed via the DiscoveryController will match the methods that have been configured by the main Doorkeeper configuration.
poudelmadhav
approved these changes
Jan 15, 2026
Member
|
Hello @kapschy . Thanks for your contribution and patience, sorry for long responses 🙏 This looks good to me, can you please rebase with the latest changes? Thanks a lot 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
pkce_code_challenge_methods_supportedare hardcoded to["plain", "S256"]. This could cause a mismatch between the configured challenge methods in the base Doorkeeper configuration and those that are advertised at the/.well-known/openid-configurationendpoint.Updates the method to delegate to
doorkeeper#pkce_code_challenge_methodsso that the supported methods exposed via theDiscoveryControllerwill match the methods that have been configured by the main Doorkeeper configuration.