Make redirect_uri optional for Authorization request#1701
Draft
Make redirect_uri optional for Authorization request#1701
Conversation
| .symbolize_keys | ||
| end | ||
|
|
||
| def allow_blank_redirect_uri? |
Contributor
There was a problem hiding this comment.
It may be better to phrase this in the way that the spec reads, so: require_redirect_uri? and then check present? instead of blank?
Contributor
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
There was a problem hiding this comment.
This looks good, but we'll need tests to confirm it works, only comment is about making the allow_blank_redirect_uri? into the same language as the spec: require_redirect_uri?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1682 and #1678