Conversation
Also: Update the `setup-uv` action to v7
This same example will be tested in the `node-hub` repo as part of dora-rs/dora-hub#23 Testing with external deps will likely lead to version mismatches of the message crate. So it requires synchronous changes to two repos, which makes development difficult.
|
@haixuanTao The plot node of the object detection example seems to fail. Perhaps we're missing some special handling of the Also, the keyboard example requires some |
|
This is the full log output of the failed object detection job by the way: 12_Object detection dataflow.zip |
|
Yes for rerun we need: Which is basically a headless mode. I don't think we should test all examples as it's going to take a lot of CI times and some like keyboard requires hardware. I think testing as it was before was enough as is. There is unit test run at the node level and I think that this is enough. |
|
Thanks I'll try that!
I thought you wanted to keep the object detection/yolo example running on CI to ensure that we don't accidentally break something? Even with unit tests, I still think that we should run the examples on CI to ensure that they work as expected. The unit tests also seem a bit sparse in many cases, for example for dora-yolo: def test_import_main():
"""TODO: Add docstring."""
from dora_yolo.main import main
# Check that everything is working, and catch dora Runtime Exception as we're not running in a dora dataflow.
with pytest.raises(RuntimeError):
main()It looks like this test just verifies that the node initialization fails without even running the event loop. |
|
Hmm, I still get the same error after b93aa93 . Any other ideas? |
|
So |
|
@claude could you move OPERATING_MODE: SAVE within the env of dora up so that when the daemon is spawned the env variable is available |
Sorry I was reference example beyond what was originally tested within the dora CI. I think there is example within this PR that was not covered before. |
It must be set for `dora up`
|
Yes, I try to run as many examples as possible to ensure that they are and keep working. If the CI time is a concern we can of course modify the job to run less often, e.g. only on commits to main and not for PRs |
This PR adds CI jobs for the examples in this repo.
Fixes #1