This repository was archived by the owner on Mar 31, 2024. It is now read-only.
Conversation
The encoding of the CDR format is different for different data types. For example, structs are encoded differently than maps. Since Python does not provide native equivalents to all CDR types, we need to some type conversion to the type specified in the `msg` files. This commit starts implementing such a system through a new `TypeInfo` enum, which we will generate from the ROS2 msg files at runtime. For serialization, we now use a custom `TypedValue` type that calls the correct `serialize_x` functions of serde.
Also: implement f64 support to support Twist message.
ROS2/DDS seems to require a specific type name format for messages.
There is no need for the input data to live exactly as long as the deserializer.
Allows us to reuse the structs for a DeserializeSeed implementation in the future.
This makes it easier to support DeserializeSeed-based deserialization.
This way we don't need to specify the bound everywhere.
…lient`/`rustdds`
In favor of separate repo.
Contributor
Author
|
I moved out the |
Contributor
Author
|
Given that it might take some time until the upstream changes are merged, I don't think that we should wait for it. The |
Contributor
|
I see. Sure. Having git dependenccy in the |
Contributor
Author
|
Ok great! Do you want to do a quick review or are you fine with merging this as-is? |
haixuanTao
approved these changes
Jul 21, 2023
Contributor
|
I'm okay with merging this as is, as there is not a lot history to begin with. I'll test maybe later if that's ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dora-ros2-bridgecrate viapip, so we don't want to generate the ROS2 message structs at build time.msg-gencrate that was created in Split parsing into separate crate #1.dora-ros2-bridge-pythoncrate that usesmaturinandpyo3to be usable from Python.dora-ros2-bridgewithout default features, i.e. without compile-time ROS2 message generation.pythonizecrate.