Skip to content

Commit dcbf7c0

Browse files
committed
Use UV_PROJECT_ENVIRONMENT env variable to simplify venv handling
Also: Run the new example added in #1298
1 parent 894afce commit dcbf7c0

File tree

1 file changed

+7
-37
lines changed

1 file changed

+7
-37
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -369,10 +369,12 @@ jobs:
369369
shell: bash
370370
run: |
371371
uv venv --seed -p 3.12
372+
373+
# Set UV_PROJECT_ENVIRONMENT for all following steps
372374
if [ "$RUNNER_OS" != "Windows" ]; then
373-
source .venv/bin/activate
375+
echo "UV_PROJECT_ENVIRONMENT=$PWD/.venv" >> "$GITHUB_ENV"
374376
else
375-
source .venv/Scripts/activate
377+
echo "UV_PROJECT_ENVIRONMENT=$PWD/.venv" >> "$GITHUB_ENV"
376378
fi
377379
378380
uv pip install -e apis/python/node
@@ -383,12 +385,6 @@ jobs:
383385
# fail-fast by using bash shell explicitly
384386
shell: bash
385387
run: |
386-
if [ "$RUNNER_OS" != "Windows" ]; then
387-
source .venv/bin/activate
388-
else
389-
source .venv/Scripts/activate
390-
fi
391-
392388
# Test Python template Project
393389
dora new test_python_project --lang python --internal-create-with-path-dependencies
394390
cd test_python_project
@@ -422,12 +418,6 @@ jobs:
422418
env:
423419
RUST_LOG: info
424420
run: |
425-
if [ "$RUNNER_OS" != "Windows" ]; then
426-
source .venv/bin/activate
427-
else
428-
source .venv/Scripts/activate
429-
fi
430-
431421
echo "Running Python Node Example"
432422
dora up
433423
dora build examples/python-dataflow/dataflow.yml --uv
@@ -440,12 +430,6 @@ jobs:
440430
# fail-fast by using bash shell explicitly
441431
shell: bash
442432
run: |
443-
if [ "$RUNNER_OS" != "Windows" ]; then
444-
source .venv/bin/activate
445-
else
446-
source .venv/Scripts/activate
447-
fi
448-
449433
echo "Running Python Node Dynamic Example"
450434
dora build examples/python-dataflow/dataflow_dynamic.yml --uv
451435
dora start examples/python-dataflow/dataflow_dynamic.yml --name ci-python-dynamic --detach --uv
@@ -458,12 +442,6 @@ jobs:
458442
# fail-fast by using bash shell explicitly
459443
shell: bash
460444
run: |
461-
if [ "$RUNNER_OS" != "Windows" ]; then
462-
source .venv/bin/activate
463-
else
464-
source .venv/Scripts/activate
465-
fi
466-
467445
echo "Running CI Operator Test"
468446
dora build examples/python-operator-dataflow/dataflow.yml --uv
469447
dora start examples/python-operator-dataflow/dataflow.yml --name ci-python-operator --detach --uv
@@ -476,11 +454,6 @@ jobs:
476454
# fail-fast by using bash shell explicitly
477455
shell: bash
478456
run: |
479-
if [ "$RUNNER_OS" != "Windows" ]; then
480-
source .venv/bin/activate
481-
else
482-
source .venv/Scripts/activate
483-
fi
484457
echo "Running Python object detection example with external deps"
485458
dora build examples/python-dataflow/dataflow-object-detection.yml --uv
486459
dora start examples/python-dataflow/dataflow-object-detection.yml --name ci-python-obj-det --detach --uv
@@ -512,15 +485,12 @@ jobs:
512485
- name: "Python Queue Latency + Timeout Test"
513486
timeout-minutes: 30
514487
run: dora run tests/queue_size_and_timeout_python/dataflow.yaml --uv
488+
- name: "Test Python Example: Multiple Arrays"
489+
timeout-minutes: 30
490+
run: dora run examples/python-multiple-arrays/dataflow.yml --uv
515491
- name: "Python Object Detection Node Example"
516492
timeout-minutes: 30
517493
run: |
518-
if [ "$RUNNER_OS" != "Windows" ]; then
519-
source .venv/bin/activate
520-
else
521-
source .venv/Scripts/activate
522-
fi
523-
524494
echo "Running Python Object Detection Node Example"
525495
dora up
526496
dora build examples/python-dataflow/dataflow-object_detection.yml --uv

0 commit comments

Comments
 (0)