feat(cli): add --mode flag to dora build for parallel/sequential builds#1573
Open
swar09 wants to merge 4 commits intodora-rs:mainfrom
Open
feat(cli): add --mode flag to dora build for parallel/sequential builds#1573swar09 wants to merge 4 commits intodora-rs:mainfrom
--mode flag to dora build for parallel/sequential builds#1573swar09 wants to merge 4 commits intodora-rs:mainfrom
Conversation
Contributor
Author
|
I have figured out the issue which cause CI failure i will update soon . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1570
As of now,
dora build dataflow.ymlbuilds nodes one at a time. This is safe for low-spec hardware but wastes time on capable development machines. This PR adds a--modeflag todora buildso users can opt into parallel building.Usage
Note
The feature is most valuable for use cases like dataflows with Python, Rust, and C/C++ nodes from separate projects.
Works for Any combination of independent build commands.
For a pure Rust workspace with all nodes inside it, the gain is minimal because Cargo itself serializes via locks.