-
Notifications
You must be signed in to change notification settings - Fork 480
Migrate analytics portlet #34303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate analytics portlet #34303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the analytics portlet from SCSS-based styling to Tailwind CSS classes, upgrades to PrimeNG 21, and integrates analytics into the Next.js example. The changes represent a significant frontend modernization effort.
Changes:
- Converted SCSS stylesheets to inline Tailwind CSS classes across all analytics portlet components
- Updated PrimeNG component imports and usage patterns for version 21 compatibility
- Added browser API mocks (MutationObserver, IntersectionObserver, ResizeObserver) for PrimeNG 21 testing requirements
- Integrated
@dotcms/analyticspackage into the Next.js example with DotContentAnalytics component
Reviewed changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/nextjs/src/app/layout.js | Adds DotContentAnalytics component and imports missing config file |
| examples/nextjs/package.json | Adds @dotcms/analytics dependency |
| core-web/libs/portlets/dot-analytics/portlet/tsconfig.spec.json | Updates module type and adds isolatedModules for PrimeNG 21 |
| core-web/libs/portlets/dot-analytics/portlet/src/test-setup.ts | Adds browser API mocks for PrimeNG 21 compatibility |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-search/* | Replaces SCSS with Tailwind classes in component host and template |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-error/* | Removes SCSS file and applies Tailwind classes inline |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/* | Migrates all dashboard components from SCSS to Tailwind CSS |
| Multiple component spec files | Updates test selectors and mock setup for PrimeNG 21 changes |
...cs-dashboard/components/dot-analytics-state-message/dot-analytics-state-message.component.ts
Show resolved
Hide resolved
...hboard/components/dot-analytics-dashboard-table/dot-analytics-dashboard-table.component.html
Outdated
Show resolved
Hide resolved
...t-analytics-dashboard-pageview-report/dot-analytics-dashboard-pageview-report.component.html
Outdated
Show resolved
Hide resolved
...t-analytics-dashboard-pageview-report/dot-analytics-dashboard-pageview-report.component.html
Outdated
Show resolved
Hide resolved
...t-analytics-content-conversions-table/dot-analytics-content-conversions-table.component.html
Outdated
Show resolved
Hide resolved
...alytics-dashboard-conversions-report/dot-analytics-dashboard-conversions-report.component.ts
Outdated
Show resolved
Hide resolved
...ortlets/dot-analytics/portlet/src/lib/dot-analytics-search/dot-analytics-search.component.ts
Outdated
Show resolved
Hide resolved
...analytics-conversions-overview-table/dot-analytics-conversions-overview-table.component.html
Outdated
Show resolved
Hide resolved
...analytics-conversions-overview-table/dot-analytics-conversions-overview-table.component.html
Outdated
Show resolved
Hide resolved
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. GPL-2.0 MPL-2.0
|
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0 |
Description
This PR completes the migration of the Analytics portlet UI to PrimeNG 21 and Angular 21 standalone components, ensuring visual consistency and modern UX patterns across the DotCMS admin interface.
Testing
Checklist
Visual Impact
Screen.Recording.2026-01-15.at.9.49.56.AM.mov
This PR fixes: #34253
This PR fixes: #34253