fix(graphql-codegen-cli): Don't hang when 0 CPUs are found #10569
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba4b87c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etr2460
force-pushed
the
fix-zero-length-cpus
branch
from
f7f2b46 to
ba4b87c
Compare
eddeee888
reviewed
Jan 11, 2026
| }); | ||
|
|
||
| return task.newListr(generateTasks, { concurrent: cpus().length }); | ||
| return task.newListr(generateTasks, { concurrent: cpus().length || 1 }); |
Collaborator
There was a problem hiding this comment.
Good point about having unit tests here may not be useful 🤔
Even if we mocked cpus(), I can't think of a good (or meaningful) way to assert that it works.
Agree with merging this first, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes generation when 0 CPUs are returned by
os.cpus(). This happens in sandbox environments. Note that I did not replaceos.cpus()withos.availableParallelism()as that was added in v18 of node and thepackage.jsonspecifies v16 as the min version. This change matches how node v18 and up implements availableParallelism (source)Related #10506
Type of change
Please delete options that are not relevant.
Further comments
As this is a rather trivial change, I didn't add a new unit test for it (would involve mocking
os.cpuswhich didn't seem especially useful). I'm happy to add a test if folks feel it's valuable though!