Skip to content

Re-implement inputMaybeValue to allow changing Variables and Input nullable types #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddeee888 merged 6 commits into from
Jan 15, 2026
+340 −241
Merged

Re-implement inputMaybeValue to allow changing Variables and Input nullable types #10573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40e0dfe
Shuffle methods to group things together, cleanup
eddeee888 Jan 15, 2026
1728699
Wire up _inputMaybeValue and organise config
eddeee888 Jan 15, 2026
6717d58
Wire up inputMaybeValue
eddeee888 Jan 15, 2026
b166cf8
Add inputMaybeValue test
eddeee888 Jan 15, 2026
30216a1
Update tests
eddeee888 Jan 15, 2026
adb5b53
Add changeset
eddeee888 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-poets-doubt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphql-codegen/typescript-operations': patch
---

Re-implement inputMaybeValue
8 changes: 4 additions & 4 deletions dev-test/githunt/typed-document-nodes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -73,8 +73,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.avoidOptionals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit: number | null;
offset: number | null;
limit: number | null | undefined;
offset: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset: number | null;
limit: number | null;
offset: number | null | undefined;
limit: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.enumsAsTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.flatten.preResolveTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -48,8 +48,8 @@ export type CurrentUserForProfileQuery = { currentUser: { login: string; avatar_

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.immutableTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -74,8 +74,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.preResolveTypes.onlyOperationTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.preResolveTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
8 changes: 4 additions & 4 deletions dev-test/githunt/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export type OnCommentAddedSubscription = {

export type CommentQueryVariables = Exact<{
repoFullName: string;
limit?: number | null;
offset?: number | null;
limit?: number | null | undefined;
offset?: number | null | undefined;
}>;

export type CommentQuery = {
Expand Down Expand Up @@ -72,8 +72,8 @@ export type FeedEntryFragment = {

export type FeedQueryVariables = Exact<{
type: FeedType;
offset?: number | null;
limit?: number | null;
offset?: number | null | undefined;
limit?: number | null | undefined;
}>;

export type FeedQuery = {
Expand Down
2 changes: 1 addition & 1 deletion dev-test/standalone-operations/import-schema-types/_types.generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type * as Types from './_base.generated.js';
type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
export type WithVariablesQueryVariables = Exact<{
role?: Types.UserRole | null;
role?: Types.UserRole | null | undefined;
}>;

export type WithVariablesQuery = { user: { id: string; name: string } | null };
20 changes: 10 additions & 10 deletions dev-test/star-wars/types.avoidOptionals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ export type CreateReviewForEpisodeMutationVariables = Exact<{
export type CreateReviewForEpisodeMutation = { createReview: { stars: number; commentary: string | null } | null };

export type ExcludeQueryAlphaQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type ExcludeQueryAlphaQuery = { hero: { name: string } | { name: string } | null };

export type ExcludeQueryBetaQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type ExcludeQueryBetaQuery = { hero: { name: string } | { name: string } | null };

export type HeroAndFriendsNamesQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroAndFriendsNamesQuery = {
Expand All @@ -46,7 +46,7 @@ export type HeroAppearsInQuery = {
};

export type HeroDetailsQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroDetailsQuery = {
Expand All @@ -60,35 +60,35 @@ type HeroDetails_Human_Fragment = { height: number | null; name: string };
export type HeroDetailsFragment = HeroDetails_Droid_Fragment | HeroDetails_Human_Fragment;

export type HeroDetailsWithFragmentQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroDetailsWithFragmentQuery = {
hero: { primaryFunction: string | null; name: string } | { height: number | null; name: string } | null;
};

export type HeroNameQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroNameQuery = { hero: { name: string } | { name: string } | null };

export type HeroNameConditionalInclusionQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
includeName: boolean;
}>;

export type HeroNameConditionalInclusionQuery = { hero: { name?: string } | { name?: string } | null };

export type HeroNameConditionalExclusionQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
skipName: boolean;
}>;

export type HeroNameConditionalExclusionQuery = { hero: { name?: string } | { name?: string } | null };

export type HeroParentTypeDependentFieldQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroParentTypeDependentFieldQuery = {
Expand All @@ -99,7 +99,7 @@ export type HeroParentTypeDependentFieldQuery = {
};

export type HeroTypeDependentAliasedFieldQueryVariables = Exact<{
episode: Episode | null;
episode: Episode | null | undefined;
}>;

export type HeroTypeDependentAliasedFieldQuery = {
Expand Down
18 changes: 9 additions & 9 deletions dev-test/star-wars/types.excludeQueryAlpha.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ export type CreateReviewForEpisodeMutationVariables = Exact<{
export type CreateReviewForEpisodeMutation = { createReview: { stars: number; commentary: string | null } | null };

export type ExcludeQueryBetaQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type ExcludeQueryBetaQuery = { hero: { name: string } | { name: string } | null };

export type HeroAndFriendsNamesQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroAndFriendsNamesQuery = {
Expand All @@ -40,7 +40,7 @@ export type HeroAppearsInQuery = {
};

export type HeroDetailsQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroDetailsQuery = {
Expand All @@ -54,35 +54,35 @@ type HeroDetails_Human_Fragment = { height: number | null; name: string };
export type HeroDetailsFragment = HeroDetails_Droid_Fragment | HeroDetails_Human_Fragment;

export type HeroDetailsWithFragmentQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroDetailsWithFragmentQuery = {
hero: { primaryFunction: string | null; name: string } | { height: number | null; name: string } | null;
};

export type HeroNameQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroNameQuery = { hero: { name: string } | { name: string } | null };

export type HeroNameConditionalInclusionQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
includeName: boolean;
}>;

export type HeroNameConditionalInclusionQuery = { hero: { name?: string } | { name?: string } | null };

export type HeroNameConditionalExclusionQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
skipName: boolean;
}>;

export type HeroNameConditionalExclusionQuery = { hero: { name?: string } | { name?: string } | null };

export type HeroParentTypeDependentFieldQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroParentTypeDependentFieldQuery = {
Expand All @@ -93,7 +93,7 @@ export type HeroParentTypeDependentFieldQuery = {
};

export type HeroTypeDependentAliasedFieldQueryVariables = Exact<{
episode?: Episode | null;
episode?: Episode | null | undefined;
}>;

export type HeroTypeDependentAliasedFieldQuery = {
Expand Down
Loading