[typescript-operations] Handle printing types consistently when types are any and unknown
#10574
+75
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly, especially for any and unknown
🦋 Changeset detectedLatest commit: d2aa8f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
6.1.1-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
5.0.1-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
7.0.0-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
5.0.8-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
5.1.3-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
6.0.0-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
6.0.0-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
6.1.6-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
6.0.0-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
6.0.0-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
5.1.3-alpha-20260117105221-d2aa8f22f154fadab9ac34896ea317a18b05f4d6 |
npm ↗︎ unpkg ↗︎ |
eddeee888
changed the title
any and unknownany and unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a TypeScript type is
anyandunknown, and we try to add other union options e.g.any | null | undefined, they'd be collapsed down to theanyorunknown.This PR adds
printTypeScriptTypeto consistently print TypeScript types with these scenarios in mind.Note: this function doesn't exhaustively does all scenarios right now (maybe it shouldn't, otherwise, it'd be too many cases? 🤔 ). Anyways, adding it here for consistency and we can see how it evoles.
Related #10496
Type of change
Please delete options that are not relevant.