Issue #415: Increased PHPStan level to 8

Signed-off-by: alexmerlin <[email protected]>

Author: alexmerlin

src/App/src/Template/Parser.php

@@ -8,7 +8,6 @@
 use Mezzio\Helper\UrlHelperInterface;
 
 use function array_key_exists;
-use function assert;
 use function sprintf;
 
 class Parser implements ParserInterface
@@ -48,10 +47,7 @@ public function absoluteUrl(string $path, ?string $baseUrl = null): string
             $baseUrl = $this->globals['application']['url'] ?? '';
         }
 
-        $absoluteUrl = sprintf('%s%s', $baseUrl, $path);
-        assert($absoluteUrl !== '');
-
-        return $absoluteUrl;
+        return sprintf('%s%s', $baseUrl, $path);
     }
 
     public function url(
@@ -61,10 +57,7 @@ public function url(
         ?string $fragmentIdentifier = null,
         array $options = []
     ): string {
-        $url = $this->urlHelper->generate($routeName, $routeParams, $queryParams, $fragmentIdentifier, $options);
-        assert($url !== '');
-
-        return $url;
+        return $this->urlHelper->generate($routeName, $routeParams, $queryParams, $fragmentIdentifier, $options);
     }
 
     /**

src/App/src/Template/ParserInterface.php

@@ -15,7 +15,6 @@ public function __invoke(string $path, array $params = []): void;
     /**
      * @param non-empty-string $path
      * @param non-empty-string|null $baseUrl
-     * @return non-empty-string
      */
     public function absoluteUrl(string $path, ?string $baseUrl = null): string;
 
@@ -25,7 +24,6 @@ public function absoluteUrl(string $path, ?string $baseUrl = null): string;
      * @param array<non-empty-string, mixed> $queryParams
      * @param non-empty-string|null $fragmentIdentifier
      * @param array<non-empty-string, mixed> $options
-     * @return non-empty-string
      */
     public function url(
         ?string $routeName = null,