Issue #415: Increased PHPStan level to 8

Signed-off-by: alexmerlin <[email protected]>

Author: alexmerlin

src/Core/src/Security/src/Entity/OAuthAccessToken.php

@@ -233,13 +233,17 @@ private function convertToJWT(): Token
             throw new RuntimeException('Unable to convert to JWT without config');
         }
 
+        /** @var non-empty-string $audiences */
+        $audiences = $this->getClient()->getIdentifier();
+        /** @var non-empty-string $subject */
+        $subject = (string) $this->getUserIdentifier();
         return $this->jwtConfiguration->builder()
-            ->permittedFor($this->getClient()->getIdentifier())
+            ->permittedFor($audiences)
             ->identifiedBy($this->getIdentifier())
             ->issuedAt(new DateTimeImmutable())
             ->canOnlyBeUsedAfter(new DateTimeImmutable())
             ->expiresAt($this->getExpiryDateTime())
-            ->relatedTo((string) $this->getUserIdentifier())
+            ->relatedTo($subject)
             ->withClaim('scopes', $this->getScopes())
             ->getToken($this->jwtConfiguration->signer(), $this->jwtConfiguration->signingKey());
     }

src/Core/src/Security/src/Entity/OAuthClient.php

@@ -25,7 +25,6 @@ class OAuthClient implements ClientEntityInterface
     #[ORM\JoinColumn(name: 'user_id', referencedColumnName: 'uuid', nullable: true)]
     private ?User $user = null;
 
-    /** @var non-empty-string $name */
     #[ORM\Column(name: 'name', type: 'string', length: 40)]
     private string $name;
 
@@ -70,27 +69,18 @@ public function getIdentity(): string
         return $this->getName();
     }
 
-    /**
-     * @return non-empty-string
-     */
     public function getIdentifier(): string
     {
         return $this->getName();
     }
 
-    /**
-     * @param non-empty-string $name
-     */
     public function setName(string $name): self
     {
         $this->name = $name;
 
         return $this;
     }
 
-    /**
-     * @return non-empty-string
-     */
     public function getName(): string
     {
         return $this->name;