-
Notifications
You must be signed in to change notification settings - Fork 6
Issue #435: Implement dotkernel/dot-maker in dev mode
#436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexmerlin <[email protected]>
dotkernel/dot-maker in **dev** modedotkernel/dot-maker in dev mode
Jurj-Bogdan
approved these changes
Sep 3, 2025
Member
Jurj-Bogdan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script not timing out could be useful for anyone editing files as they're added, so it sounds good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Added the
"process-timeout": 0configuration that tells Composer scripts not to timeout after 5 minutes.If we are ok with them timing out, I will remove the
process-timeoutconfig.Read more on process-timeout.
I tried disabling timeout only for dot-maker, but that did not work, exiting with this message:
Note
Added a new Composer script
make.If we want to use a different command, I can change it.